Tested it, my nodes are stable since 1.5h now, ping sent every 20mins like clockwork, last seen on drk.mn max 20mins as well - awesome!Aaaaaalright! New patch suggestion
To let remote nodes correctly send dseep this line https://github.com/darkcoin/darkcoin/blob/master/src/activemasternode.cpp#L127 should be
Also there is a bug in ThreadCheckDarkSendPoolCode:
if(isCapableMasterNode != MASTERNODE_IS_CAPABLE && isCapableMasterNode != MASTERNODE_REMOTELY_ENABLED) return;
It would work fine if this https://github.com/darkcoin/darkcoin/blob/master/src/masternode.h#L35 wasn't an expression.
Right now it will start spam the network every 20 seconds and not minutes as it seems.
So these 4 lines https://github.com/darkcoin/darkcoin/blob/master/src/masternode.h#L34-L37 should be
It's only 2nd line that matters now but just to keep things consistent I would suggest to fix them all.Code:
#define MASTERNODE_MIN_SECONDS (5*60) #define MASTERNODE_PING_SECONDS (20*60) #define MASTERNODE_EXPIRATION_SECONDS (65*60) #define MASTERNODE_REMOVAL_SECONDS (70*60)