P2Pool P2Pool repository and python modules

moli

Grizzled Member
Aug 5, 2014
3,261
1,837
1,183
Vertoe, please rename the payment modules on github.
And rename the project to p2pool-dash.
mr.slaveg and ourlink , vertoe authored the rebranding to dash on his p2pool github 5 days ago but I'm not sure if he'll continue with this project: https://github.com/vertoe/p2pool-drk.

Today a few members have worked on fixing the code as you can see from this thread:
https://dashtalk.org/threads/attention-p2pool-users-and-node-operators.4591/

Hope you guys can join these geeks to improve our p2pool. They also hang out on IRC freenode, if you want to chat with them, /join #dashpay.

Thanks. :)
 
  • Like
Reactions: jakehaas

poiuty

Active Member
Nov 26, 2014
408
226
113
https://github.com/darkcoin/p2pool-drk/issues/9
possible fix in /p2pool/bitcoin/p2p.py
Code:
    message_inv = pack.ComposedType([
        ('invs', pack.ListType(pack.ComposedType([
            ('type', pack.EnumType(pack.IntType(32), {1: 'tx', 2: 'block', 3: 'txlock_request', 4: 'txlock_vote', 5: 'spork', 6: 'masternode_winner', 7: 'masternode_scanning_error', 8: 'unknown'})),
            ('hash', pack.IntType(256)),
        ]))),
    ])
    def handle_inv(self, invs):
        for inv in invs:
            if inv['type'] == 'tx':
                self.send_getdata(requests=[inv])
            elif inv['type'] == 'block':
                self.factory.new_block.happened(inv['hash'])
#            else:
#                print 'Unknown inv type', inv
 

jakehaas

Member
Dec 9, 2014
41
29
58
p2pools.us
I just pushed up a bunch of fixes / rebranding / refactoring to https://github.com/jakehaas/p2pool-dash

Special thanks to elbereth for his rebranding efforts!

As of right now, this fork is the most up to date version of p2pool. It includes the version 3 bump, as well as the new IDENTIFIER and PREFIX and other fixes.

Make sure that you update your node if you haven't for a few days, otherwise any blocks you find will be orphaned as version 2 (old).
 
  • Like
Reactions: moli

jakehaas

Member
Dec 9, 2014
41
29
58
p2pools.us
https://github.com/darkcoin/p2pool-drk/issues/9
possible fix in /p2pool/bitcoin/p2p.py
Code:
    message_inv = pack.ComposedType([
        ('invs', pack.ListType(pack.ComposedType([
            ('type', pack.EnumType(pack.IntType(32), {1: 'tx', 2: 'block', 3: 'txlock_request', 4: 'txlock_vote', 5: 'spork', 6: 'masternode_winner', 7: 'masternode_scanning_error', 8: 'unknown'})),
            ('hash', pack.IntType(256)),
        ]))),
    ])
    def handle_inv(self, invs):
        for inv in invs:
            if inv['type'] == 'tx':
                self.send_getdata(requests=[inv])
            elif inv['type'] == 'block':
                self.factory.new_block.happened(inv['hash'])
#            else:
#                print 'Unknown inv type', inv
Can you open this issue on https://github.com/jakehaas/p2pool-dash? It is now the most up to date version of the p2pool software.
 

poiuty

Active Member
Nov 26, 2014
408
226
113
moli, better if jakehaas create pull request, and eduffield add it.
but you can as you suggest.

we need one master git repository.
 
  • Like
Reactions: moli

jakehaas

Member
Dec 9, 2014
41
29
58
p2pools.us
poiuty is right, this really should be on the master repo.

I'm going to do a few more edits/fixes today, then create a pull request against the darkcoin/p2pool-drk master repo for Evan to merge.
 
  • Like
Reactions: moli

jakehaas

Member
Dec 9, 2014
41
29
58
p2pools.us
moli, better if jakehaas create pull request, and eduffield add it.
but you can as you suggest.

we need one master git repository.
Pull request created:
https://github.com/darkcoin/p2pool-drk/pull/10

This pull request rebrands everything Darkcoin to Dash. It also bumps the version to 3 to be compatible with the rest of the network.

To make sure deprecated nodes don't cause issues, the IDENTIFIER and PREFIX have been updated.

x11_hash and dash_subsity have been separated into their own repos for maintainability.

There are also small bug fixes here and there.
 

poiuty

Active Member
Nov 26, 2014
408
226
113
https://github.com/jakehaas/x11_hash/pull/1
Code:
sha3/groestl.c:2816:17: warning: variable ‘buf’ set but not used [-Wunused-but-set-variable]
sha3/groestl.c: In function ‘groestl_big_close’:
sha3/groestl.c:2952:17: warning: variable ‘buf’ set but not used [-Wunused-but-set-variable]
 

Klaian

New Member
Apr 12, 2015
5
4
3
I am starting to mine Dash and want to use local p2pool. I have searched around and looking for confirmation. P2pool-dash cannot run in Windows correct? If it can, anyone got a good link on method?

Thanks
 

moli

Grizzled Member
Aug 5, 2014
3,261
1,837
1,183
I am starting to mine Dash and want to use local p2pool. I have searched around and looking for confirmation. P2pool-dash cannot run in Windows correct? If it can, anyone got a good link on method?

Thanks
Here's a guide for p2pool mining on Windows: https://dashtalk.org/threads/windows-mining-walkthrough.54/

I hope that helps, if not, you can post there or here again.

EDIT: You might want to browse for more info and guides under "Mining Guides":
https://dashtalk.org/forums/mining-guides.69/
 

PatMan

New Member
Aug 15, 2014
15
6
3
Ug. Wait. What is the correct/official versions of p2pool-dash/drk, dash/darkcoin-hash & dash/darkcoin-subsidy we are supposed to be using now? I just witnessed my version total hashrate drop to less than 40mhs.

There's too many repos - can't we have just the one repo that everyone works on? With an up-to-date guide for noobs?
 

moli

Grizzled Member
Aug 5, 2014
3,261
1,837
1,183
Ug. Wait. What is the correct/official versions of p2pool-dash/drk, dash/darkcoin-hash & dash/darkcoin-subsidy we are supposed to be using now? I just witnessed my version total hashrate drop to less than 40mhs.

There's too many repos - can't we have just the one repo that everyone works on? With an up-to-date guide for noobs?
jakehaas , elbereth ,poiuty and a few others fixed/worked on the code and jakehaas submitted a pull request to dash master repo here:

https://github.com/jakehaas/p2pool-dash

You can also follow this other thread on their work: https://dashtalk.org/threads/attention-p2pool-users-and-node-operators.4591/
 

PatMan

New Member
Aug 15, 2014
15
6
3
That's exactly my point, I wasn't even aware of that one, so there's another repo to confuse matters. I repeat: What is the correct/official versions of p2pool-dash/drk, dash/darkcoin-hash & dash/darkcoin-subsidy we are supposed to be using now?

There should be one repo where everyone contributes, not several repos where a few contribute - it makes no sense & confuses everyone.
 

elbereth

Active Member
Dash Support Group
Mar 25, 2014
440
466
133
Costa Rica
dashninja.pl
Dash Address
XkfkHqMnhvQovo7kXQjvnNiFnQhRNZYCsz
That's exactly my point, I wasn't even aware of that one, so there's another repo to confuse matters. I repeat: What is the correct/official versions of p2pool-dash/drk, dash/darkcoin-hash & dash/darkcoin-subsidy we are supposed to be using now?

There should be one repo where everyone contributes, not several repos where a few contribute - it makes no sense & confuses everyone.
Complain to the core devs not accepting the pull request to the "official" p2pool-drk...
 

moli

Grizzled Member
Aug 5, 2014
3,261
1,837
1,183
That's exactly my point, I wasn't even aware of that one, so there's another repo to confuse matters. I repeat: What is the correct/official versions of p2pool-dash/drk, dash/darkcoin-hash & dash/darkcoin-subsidy we are supposed to be using now?

There should be one repo where everyone contributes, not several repos where a few contribute - it makes no sense & confuses everyone.
What I understand is originally someone named "dstorm" took care of the p2pool code but he stopped doing it. Then vertoe took over. But now vertoe is gone, so some members are trying to work on this, and they're waiting to hear from eduffield to merge their code. So we need to give them some time to get this altogether but I'm sure they'll get this straightened out. Don't worry. :)
 

PatMan

New Member
Aug 15, 2014
15
6
3
I used to use dstorms version till it went out of date, then vertoes till it went out of date, then the "official" one that is out of date & doesn't work correctly. Having to jump around from one repo to another in an effort to finding a correct & working version is just daft & both p2pool & dash suffers as a result. I & others have had to close my node because of this - I'm not worried, but it's bad organisation that harms the p2pool network & dash in general.

One repo that is kept up to date is all that is required to solve the problem.
 
  • Like
Reactions: moli and darkwing