Masternode missed payment

oblox

Well-known Member
Aug 6, 2014
1,032
537
183
this might be multiple masternode set up using start-many. This pays all masternode earnings to one address.
Start-many doesn't pay to one address to my knowledge. The only way that happens is if you fund your 1k in the same tx using the add recipient button.
 
  • Like
Reactions: UdjinM6

Miner237

Well-known Member
Foundation Member
May 28, 2014
509
223
213
I thought start many wasn't really working / supported. After I moved my MN to a new wallet I got got first payment after about 1500 blocks.
 

crowning

Well-known Member
May 29, 2014
1,415
1,997
183
Alpha Centauri Bc
Dsee/dseep message propagating and MN rank calculation algo will be changed in next release (already live on testnet).
//Would be nice if someone look into code to find some flaw there though.//
The code looks (more or less, it's still a messy bit of global variables inherited from Bitcoin and therefore unnecessary hard to understand :rolleyes:) okay, but I think there's still a cleverly hidden bug somewhere.:

All my Masternodes are up to protocol version 70051
- smallest distance of payments: 184 blocks
- longest distance for payments: 2440 blocks

Right now there exist 1048 Masternodes.
 
  • Like
Reactions: UdjinM6

UdjinM6

Official Dash Dev
Dash Core Team
Moderator
May 20, 2014
3,638
3,538
1,183
The code looks (more or less, it's still a messy bit of global variables inherited from Bitcoin and therefore unnecessary hard to understand :rolleyes:) okay, but I think there's still a cleverly hidden bug somewhere.:

All my Masternodes are up to protocol version 70051
- smallest distance of payments: 184 blocks
- longest distance for payments: 2440 blocks

Right now there exist 1048 Masternodes.
That's interesting... let's watch for this one more day, should "calm down" and become more even I guess...
 

crowning

Well-known Member
May 29, 2014
1,415
1,997
183
Alpha Centauri Bc
While I had a look into the code anyway I think I found something that is not quite correct:

Code:
void CMasternodePayments::CleanPaymentList()
{
  if(pindexBest == NULL) return;

  vector<CMasternodePaymentWinner>::iterator it;
  for(it=vWinning.begin();it<vWinning.end();it++){
    if(pindexBest->nHeight - (*it).nBlockHeight > 1000){
      if(fDebug) LogPrintf("CMasternodePayments::CleanPaymentList - Removing old masternode payment - block %d\n", (*it).nBlockHeight);
      vWinning.erase(it);
      break;
    }
  }
}
Me thinks

if(pindexBest->nHeight - (*it).nBlockHeight > 1000)

should be

if(pindexBest->nHeight - (*it).nBlockHeight > darkSendMasterNodes.size())
 

crowning

Well-known Member
May 29, 2014
1,415
1,997
183
Alpha Centauri Bc
All my Masternodes are up to protocol version 70051
- smallest distance of payments: 184 blocks
- longest distance for payments: 2440 blocks
Another update: 184 (and a 274 in between) and 3061 blocks with 1153 Masternodes online.

Things start to become interesting.
 

jiggytom

Member
Nov 14, 2014
104
22
68
After having some issues with masternode payments, my 2 nodes have gotten paid 2 times each in past 2 days. The updates probably helped this and knocked off those who weren't updated.
 

maky

Member
Nov 14, 2014
71
32
58
I hope problem is resolved.

Payment after 3773 blocks (nice number) on all-time working and up-to-date MN.
 

moocowmoo

Bovine Bit-flipper
Foundation Member
Jun 15, 2014
483
603
263
masternode.me
Dash Address
XmoocowYfrPKUR6p6M5aJZdVntQe71irCX
I got a double payment (four hours apart) just an hour ago.

12/08/2014 10:14 e32d3667e9317d63ce91e72302eae612cc496bbf0a187bace5a6ce794c9cc1e1
12/08/2014 16:24 36e09f606101d050f3ecce98dc3a06554da11da67eda0dd88dffb3b964b53c17

edit:
and another on a different masternode (20 hours this time)

12/07/2014 19:05 2b43892f35c3f88245fe6e84f9a0bc80af6a2c5ffaba5e5229f18923a74700a1
12/08/2014 17:57 e40563cc6bf2ccb4ae747f6e2ab12d8ad43b2c4c4a7e1cd7c8bc3189beb1264f
 
Last edited by a moderator:

eduffield

Core Developer
Mar 9, 2014
1,084
5,319
183
I got a double payment (four hours apart) just an hour ago.

12/08/2014 10:14 e32d3667e9317d63ce91e72302eae612cc496bbf0a187bace5a6ce794c9cc1e1
12/08/2014 16:24 36e09f606101d050f3ecce98dc3a06554da11da67eda0dd88dffb3b964b53c17

edit:
and another on a different masternode (20 hours this time)

12/07/2014 19:05 2b43892f35c3f88245fe6e84f9a0bc80af6a2c5ffaba5e5229f18923a74700a1
12/08/2014 17:57 e40563cc6bf2ccb4ae747f6e2ab12d8ad43b2c4c4a7e1cd7c8bc3189beb1264f
The round robin only starts when the reference node actually starts. It doesn't have a persistent history, so dup payments are likely for the first 24-48 hours each time I upgrade it (which happened this morning, again). I'd fix it, but I want to get rid of the reference node anyway.
 

oblox

Well-known Member
Aug 6, 2014
1,032
537
183
The round robin only starts when the reference node actually starts. It doesn't have a persistent history, so dup payments are likely for the first 24-48 hours each time I upgrade it (which happened this morning, again). I'd fix it, but I want to get rid of the reference node anyway.
Patrick was mentioning ideas about how to do without them, any ideas if it's plausible in the near term or still other things ahead of schedule? I'd imagine at this point, it will be more of splitting tasks for feature implementation, no?
 

jpr

Active Member
May 11, 2014
493
393
133
I got 1.5 payment yesterday and about 23 hours later I just got 1.79 payment :)
 

CODERsp

Member
Jul 5, 2014
114
35
78
Also, I tried to fix masternode by "masternode stop" and "masternode start". Was it bad idea?
 

oblox

Well-known Member
Aug 6, 2014
1,032
537
183
Also, I tried to fix masternode by "masternode stop" and "masternode start". Was it bad idea?
How long was it stopped? If it was too long, you might be bumped to the end of the queue.
 

crowning

Well-known Member
May 29, 2014
1,415
1,997
183
Alpha Centauri Bc
Another update: 184 (and a 274 in between) and 3061 blocks with 1153 Masternodes online.

Things start to become interesting.
4160 blocks without payment. Maybe this Masternode only accepts cheques?


Edit: after 4419 blocks the cheque finally arrived. New world record...
 
Last edited by a moderator:

CODERsp

Member
Jul 5, 2014
114
35
78
My second masternode had no payments yet, so I decided to reinstall it. It worked under send-many command and after last update I moved it to dedicated wallet, but I copied datadir instead of downloading it from peers. Also, I used the same privkey and didn't create zero-address. So, maybe reinstallation will help. I'll post about results later.
 

Shaan

New Member
Nov 1, 2014
8
6
3
explorer.darkcoin.fr/address/Xhx4GhrBBSyJUDYAEShQuFRpjGrbMJRhEG

my MN missed payments

nov 13-20 = 7 days.
de 6-10 = 4 days

total of 11 days missed can someone please explain this thanks.
 

jiggytom

Member
Nov 14, 2014
104
22
68
And now I have a node that hasn't been paid in ~2300 blocks after getting paid twice regularly. Something is clearly not right.
 

crowning

Well-known Member
May 29, 2014
1,415
1,997
183
Alpha Centauri Bc
And now I have a node that hasn't been paid in ~2300 blocks after getting paid twice regularly. Something is clearly not right.
That's still within the specification, because Evan said in the posting above that the payment reference node does NOT persist the payment history.

Worst possible case:

  • lets say we have 1400 Masternodes. Normally you would get paied (worst case) after 1400 blocks
  • Evan has (for whatever reason) to restart the node when we're at block 1399, so you did NOT get our payment.
  • Lets again assume the worst case would be that your Masternode is the last one in the list.
  • that makes 1399 + 1400 = 2799 blocks
Of course if Evan has to start the node even more often things become really bad, see my example with 4419 blocks.

That's one of the reasons the payment reference node is only a temporary solution and we want to get rid of it.
 
  • Like
Reactions: UdjinM6