P2Pool P2Pool repository and python modules

[jakehaas]

The most recent block "found" by p2pool is
http://explorer.darkcoin.io/block/000000000010cb98a85915145e48a0d8f27e830c5c0a174e5da69eb784f3b50c

My p2pool mining address is listed there, but I never received the coins in my wallet (which is up to date, and synced).

The odd part is if I look up that address on the same explorer, it doesn't show that transaction.... even though the transaction shows my address listed.

 

[Byuo]

Go to the previous block and you will see two blocks for 'Next block'. The accepted block is version 3 and the second block is the p2pool block which is version 2. All blocks since 245799 are rejected.

 

[jakehaas]

Does that mean whatever p2pool node found the block was running a version of p2pool before this commit?
https://github.com/thelazier/p2pool-dash/commit/9b99c17f1e2600e99c3eb27270a5753d2e4bf30b

 

[jakehaas]

https://github.com/darkcoin/p2pool-drk/pull/8

 

[jakehaas]

Block http://explorer.darkcoin.io/block/00000000000855739b96f0cf8b756c82a0f1386b2b8a9ccbf4e53d28bf00ce2d

was found via p2pool after using the pull request above.


No more double blocks and I can confirm payments were successful.


The only problem is that we are only node to patch this so far.... and we are only 10% of the p2pool network so the majority of p2pool blocks being found are rejected...

 

[thefrog]

Hi
http://eu.p2pool.sk:7903
updated with the Bump version 3.
Feel free to use it.

 

[poiuty]

So let`s update IDENTIFIER and PREFIX => remove who dont update to 3 version
https://github.com/darkcoin/p2pool-drk/pull/7

 

[jakehaas]

https://github.com/jakehaas/p2pool-drk

contains all the fixes to make p2pool functional again until the main repo can be updated.

 

[poiuty]

Now ~70Mh/s on version 3 and new IDENTIFIER, PREFIX.

 

[jakehaas]

dash.p2pools.us

switched to new IDENTIFIER, PREFIX. Should have added ~100 MH/s.

 

[poiuty]

Also, we have one old bug => let`s try to fix it.
https://github.com/darkcoin/p2pool-drk/issues/9

 

[moli]

Vertoe, please rename the payment modules on github.
And rename the project to p2pool-dash.

mr.slaveg and ourlink , vertoe authored the rebranding to dash on his p2pool github 5 days ago but I'm not sure if he'll continue with this project: https://github.com/vertoe/p2pool-drk.

Today a few members have worked on fixing the code as you can see from this thread:
https://dashtalk.org/threads/attention-p2pool-users-and-node-operators.4591/

Hope you guys can join these geeks to improve our p2pool. They also hang out on IRC freenode, if you want to chat with them, /join #dashpay.

Thanks. :smile:

 

[poiuty]

https://github.com/darkcoin/p2pool-drk/issues/9
possible fix in /p2pool/bitcoin/p2p.py

    message_inv = pack.ComposedType([
        ('invs', pack.ListType(pack.ComposedType([
            ('type', pack.EnumType(pack.IntType(32), {1: 'tx', 2: 'block', 3: 'txlock_request', 4: 'txlock_vote', 5: 'spork', 6: 'masternode_winner', 7: 'masternode_scanning_error', 8: 'unknown'})),
            ('hash', pack.IntType(256)),
        ]))),
    ])
    def handle_inv(self, invs):
        for inv in invs:
            if inv['type'] == 'tx':
                self.send_getdata(requests=[inv])
            elif inv['type'] == 'block':
                self.factory.new_block.happened(inv['hash'])
#            else:
#                print 'Unknown inv type', inv

 

[poiuty]

Guys, update networks.py
Drop p2pools who not update 3 version.
https://github.com/jakehaas/p2pool-dash/commit/6f7b03966b3910f03f0fdb795c6f3c3e889521d1

IDENTIFIER='7242ef345e1bed6b'.decode('hex'),
PREFIX='3b3e1286f446b891'.decode('hex'),

p2pools (3 version, new IDENTIFIER and PREFIX) ~ 700Mh/s

 

[jakehaas]

I just pushed up a bunch of fixes / rebranding / refactoring to https://github.com/jakehaas/p2pool-dash

Special thanks to elbereth for his rebranding efforts!

As of right now, this fork is the most up to date version of p2pool. It includes the version 3 bump, as well as the new IDENTIFIER and PREFIX and other fixes.

Make sure that you update your node if you haven't for a few days, otherwise any blocks you find will be orphaned as version 2 (old).

 

[jakehaas]

https://github.com/darkcoin/p2pool-drk/issues/9
possible fix in /p2pool/bitcoin/p2p.py

    message_inv = pack.ComposedType([
        ('invs', pack.ListType(pack.ComposedType([
            ('type', pack.EnumType(pack.IntType(32), {1: 'tx', 2: 'block', 3: 'txlock_request', 4: 'txlock_vote', 5: 'spork', 6: 'masternode_winner', 7: 'masternode_scanning_error', 8: 'unknown'})),
            ('hash', pack.IntType(256)),
        ]))),
    ])
    def handle_inv(self, invs):
        for inv in invs:
            if inv['type'] == 'tx':
                self.send_getdata(requests=[inv])
            elif inv['type'] == 'block':
                self.factory.new_block.happened(inv['hash'])
#            else:
#                print 'Unknown inv type', inv

Can you open this issue on https://github.com/jakehaas/p2pool-dash? It is now the most up to date version of the p2pool software.

 

[poiuty]

p2pools, yes.
But why? Best way if we do some fix and make pull request to master https://github.com/darkcoin/p2pool-drk

 

[thefrog]

http://eu.p2pool.sk:7903

switched to new IDENTIFIER, PREFIX

 

[elbereth]

p2pools, yes.
But why? Best way if we do some fix and make pull request to master https://github.com/darkcoin/p2pool-drk

Fixed on https://github.com/jakehaas/p2pool-dash with commit 53f8e4fdadfd8a4aa0dcc5dd2453481b1c8c5570

 

[moli]

p2pools, yes.
But why? Best way if we do some fix and make pull request to master https://github.com/darkcoin/p2pool-drk

The master version seems older and maybe still broken. Maybe eduffield needs to replace it with jakehaas' version?:
https://github.com/jakehaas/p2pool-dash