Welcome to the Dash Forum!

Please sign up to discuss the most innovative cryptocurrency!

Masternode Payment Testing - Now vs Later?

Discussion in 'Official Developer Thread' started by eduffield, Nov 4, 2014.

  1. eduffield

    eduffield Core Developer
    Dash Core Team

    Joined:
    Mar 9, 2014
    Messages:
    1,084
    Likes Received:
    5,316
    Trophy Points:
    183
    Despite the forking issues with enforcing masternode payments, the code and strategy that we're using now is looking really good. The problem was simply blocks coming in out of order, which are now properly ordered before being checked for the correct payment. I reviewed many different logs and this was the only issue I found, which caused all problems we had.

    The question to the community:

    It's pretty much impossible to test mastenode payments on testnet and some users/mining pools are very sick of updating. Should I have everyone update again, and enable enforcement on Friday? Alternatively we could wait until InstantX, which is what I'm also working on. Testing InstantX is probably still a couple weeks out, then we have the testing phase, so that could add another month or so. Alternatively, we just have the network update until it works and we move on.
     
    • Like Like x 8
  2. moocowmoo

    moocowmoo Bovine Bit-flipper
    Foundation Member Masternode Owner/Operator Moderator

    Joined:
    Jun 15, 2014
    Messages:
    479
    Likes Received:
    600
    Trophy Points:
    263
    Dash Address:
    XmoocowYfrPKUR6p6M5aJZdVntQe71irCX
    Have everyone update again, and enable enforcement on Friday. Let's shake out the bugs one layer at a time.
     
    • Like Like x 1
  3. AjM

    AjM Well-known Member
    Foundation Member Masternode Owner/Operator

    Joined:
    Jun 23, 2014
    Messages:
    1,298
    Likes Received:
    564
    Trophy Points:
    283
    I vote for waiting.
     
  4. moli

    moli Grizzled Member

    Joined:
    Aug 5, 2014
    Messages:
    3,262
    Likes Received:
    1,837
    Trophy Points:
    1,183
    I vote for waiting also.
     
    • Like Like x 1
  5. oblox

    oblox Well-known Member

    Joined:
    Aug 6, 2014
    Messages:
    1,034
    Likes Received:
    539
    Trophy Points:
    183
    I guess the most pertinent question would be how far out is InstantX. I think the overwhelming majority of the masternode owners would be for enforcement sooner than later, just from the standpoint of normalizing payouts.
     
    • Like Like x 1
  6. Ignition75

    Ignition75 Active Member

    Joined:
    May 25, 2014
    Messages:
    332
    Likes Received:
    209
    Trophy Points:
    113
    Yes I think waiting is going to be a better option, next update can be all about Instant(tx) as well, it will create quite a lot of fan fair.
     
    • Like Like x 1
  7. coingun

    coingun Active Member
    Masternode Owner/Operator

    Joined:
    Jul 8, 2014
    Messages:
    488
    Likes Received:
    400
    Trophy Points:
    133
    I'm with moocowmoo. Update once more and allow for enforcement to get turned on and work successfully.
     
    • Like Like x 1
  8. Scriptiee

    Scriptiee Member

    Joined:
    Apr 24, 2014
    Messages:
    44
    Likes Received:
    20
    Trophy Points:
    48
    I say update and enforce.

    Throwing both into the same update at a later date might hinder troubleshooting any issues with InstatntX, lets get one of these behind us asap.
     
    • Like Like x 1
  9. illodin

    illodin Member

    Joined:
    Apr 26, 2014
    Messages:
    122
    Likes Received:
    71
    Trophy Points:
    78
    I'm fine with updating often, but I only run masternodes, not pools. If people can't handle development they should gtfo and wait until it's stable imo.
     
    • Like Like x 3
  10. moli

    moli Grizzled Member

    Joined:
    Aug 5, 2014
    Messages:
    3,262
    Likes Received:
    1,837
    Trophy Points:
    1,183
    Evan said InstantX isn't going to use a fork:

    upload_2014-11-4_11-57-18.png
     
    • Like Like x 3
  11. BrainShutdown

    BrainShutdown Well-known Member
    Foundation Member

    Joined:
    Apr 8, 2014
    Messages:
    151
    Likes Received:
    72
    Trophy Points:
    188
    I agree with moocowmoo.
    Bug correction should occur one layer at a time.
     
    • Like Like x 1
  12. thelonecrouton

    thelonecrouton Well-known Member
    Foundation Member

    Joined:
    Apr 15, 2014
    Messages:
    1,139
    Likes Received:
    815
    Trophy Points:
    283
    I vote update again now. I don't really care about MN payment variance with the RC3 code, it's good enough, but if enforcement is part of the roadmap I think it's better to tackle it now.

    Updating a Masternode takes 60 seconds or less. I don't know how long updating a pool takes but I doubt it's much longer. This is an evolving coin, a few minutes of someones day now and again isn't much to ask.

    Friday sounds good - it shouldn't take weeks.
     
    • Like Like x 5
  13. Dr.Crypto

    Dr.Crypto Member

    Joined:
    Jul 9, 2014
    Messages:
    46
    Likes Received:
    32
    Trophy Points:
    58
    Update now, enforce on Friday, get a healthy network by the time InstantX is to be tested!
     
    • Like Like x 1
  14. eduffield

    eduffield Core Developer
    Dash Core Team

    Joined:
    Mar 9, 2014
    Messages:
    1,084
    Likes Received:
    5,316
    Trophy Points:
    183
    Alright, 80% wants to update. I'll push up the code and compile the update :) Thanks everyone!
     
    • Like Like x 16
  15. bituzer

    bituzer Member

    Joined:
    Apr 23, 2014
    Messages:
    118
    Likes Received:
    49
    Trophy Points:
    78
    yeah one layer at a time makes sense! maybe let people update and wait 2 or 3 weeks instead of enforcing friday. This way pools got more time and you can concentrate on instantx and got a stable base when its finished
     
  16. defunctec

    defunctec Member

    Joined:
    Jul 11, 2014
    Messages:
    103
    Likes Received:
    36
    Trophy Points:
    78
    Update now, enforce asap.

    People have their eye on dark atm, the network update should happen fast.

    But if we leave it until Friday, we have the weekend where people are away from their computers
    not able to update.

    Update the network until enforcement works. One update over two days then enforcement. If fail, repeat.

    Price may drop, mining activity could slide...

    But who cares about price at this point?

    We need a solid platform for instantx, simple as that.

    EDIT: Evan already replied!
     
    • Like Like x 5
  17. ourlink

    ourlink Well-known Member
    Foundation Member

    Joined:
    Jun 9, 2014
    Messages:
    236
    Likes Received:
    64
    Trophy Points:
    188
    Update... It's not a big deal to update the nodes and I think it would be better to work through bugs one layer at a time like other have expressed. Besides, we need to enforce asap!
     
    • Like Like x 1
  18. GermanRed+

    GermanRed+ Active Member

    Joined:
    Aug 28, 2014
    Messages:
    300
    Likes Received:
    109
    Trophy Points:
    113
    +1. We never know if there are other bugs or exploits until it works without any flaw.
     
    • Like Like x 1
  19. GermanRed+

    GermanRed+ Active Member

    Joined:
    Aug 28, 2014
    Messages:
    300
    Likes Received:
    109
    Trophy Points:
    113
    +1 for "enforce asap".
     
  20. GilAlexander

    GilAlexander Member

    Joined:
    Jun 26, 2014
    Messages:
    86
    Likes Received:
    23
    Trophy Points:
    48
    Update & enforce on Friday. It has already taken too long.
     
  21. italx

    italx Well-known Member
    Foundation Member

    Joined:
    Jul 31, 2014
    Messages:
    65
    Likes Received:
    52
    Trophy Points:
    158
    agree. It makes sense to make sure it's working and stable before making other changes.
     
  22. MangledBlue

    MangledBlue Well-known Member
    Masternode Owner/Operator

    Joined:
    Jun 28, 2014
    Messages:
    1,270
    Likes Received:
    686
    Trophy Points:
    183
    I'm with MOOCOWMOO ! !
    Have everyone update again, and enable enforcement on Friday. Let's shake out the bugs one layer at a time.


    Fix an issue - update:)


    edit: just seen Evans statement :-D

    I WILL UPDATE AFTER WORK!!!! tonight :-D



    I just love fixes :-D
    (sorry moli you lose :-* kisses)
     
  23. jimbit

    jimbit Well-known Member
    Foundation Member Masternode Owner/Operator

    Joined:
    May 23, 2014
    Messages:
    226
    Likes Received:
    103
    Trophy Points:
    203
    As much as I would rather leave well enough alone for a while.... doing things one layer at a time does make sense.
     
    • Like Like x 2
  24. Ignition75

    Ignition75 Active Member

    Joined:
    May 25, 2014
    Messages:
    332
    Likes Received:
    209
    Trophy Points:
    113
    The more I think about it the more I'm advising you to wait.

    How about Splawik/Moli/Tungfa/Tao and I work on a communication pack over the next couple of days and pre-warn Pool Operators, Exchanges, Masternode Operators and regular users?

    We can still do things in stages, however it might be better to pro-actively communicate this first.
     
    • Like Like x 1
  25. moli

    moli Grizzled Member

    Joined:
    Aug 5, 2014
    Messages:
    3,262
    Likes Received:
    1,837
    Trophy Points:
    1,183
    It's ok, we'll just update and enforce on Friday. I'm with the "pool friendly reminder" with splawik21 and oblox and we're going to email them. We'll be okay. :)

    And yes please do whatever you can help to get this going. That will be great! Thank you :)

    Edit: splawik21 said Evan will send out mass emails also.
     
    • Like Like x 2
  26. crowning

    crowning Official Dash Dev
    Core Developer Moderator

    Joined:
    May 29, 2014
    Messages:
    1,430
    Likes Received:
    2,009
    Trophy Points:
    183
    Actually if you give the usual suspects (yes, that's YOU, niceass) 1 year time until enforcement they'll update exactly after 365 days.
    366 if it happens to be a leap year.

    Enforcement NOW so we'll get that sorted!
     
    #26 crowning, Nov 4, 2014
    Last edited by a moderator: Nov 4, 2014
    • Like Like x 6
  27. splawik21

    splawik21 Grizzled Member
    Dash Core Team Foundation Member Dash Support Group

    Joined:
    Apr 8, 2014
    Messages:
    2,082
    Likes Received:
    1,415
    Trophy Points:
    1,283
    • Like Like x 4
  28. Sub-Ether

    Sub-Ether Well-known Member

    Joined:
    Mar 31, 2014
    Messages:
    1,525
    Likes Received:
    1,259
    Trophy Points:
    183
    The Sheep wants to update immediately and also feels this is the best way to solve each layer of complexity during the bug quashing phases.
     
    • Like Like x 2
  29. Stealth923

    Stealth923 Well-known Member
    Foundation Member

    Joined:
    Mar 9, 2014
    Messages:
    331
    Likes Received:
    343
    Trophy Points:
    233
    Happy to update as often as required. We are still in bug fixing and very close to a stable platform.

    As previously said lets layer fixes one at a time to limit troubleshooting complications later on. InstantX is such a large update I would rather have everything else perfect before we attempt it :)
     
    • Like Like x 1
  30. Raico

    Raico Well-known Member
    Foundation Member Dash Support Group

    Joined:
    May 28, 2014
    Messages:
    139
    Likes Received:
    143
    Trophy Points:
    193
    progress is never easy.
    Dev team, just do what you need to do~
    Vote for Friday~
     
    • Like Like x 2

Share This Page