Welcome to the Dash Forum!

Please sign up to discuss the most innovative cryptocurrency!

Wallet unlock bug

Discussion in 'Development Tech Discussion' started by Kong, Dec 12, 2014.

  1. Kong

    Kong Member

    Joined:
    Apr 9, 2014
    Messages:
    55
    Likes Received:
    15
    Trophy Points:
    48
    The function "walletpassphrase <passphrase> <timeout>" doesn't work as it should. I tried this function several times, but after one transaction the wallet gets locked again.

    I am using v0.10.17.23-g6be18c6-beta version of the wallet.

    Could anyone try to reproduce?
     
  2. tungfa

    tungfa Administrator
    Dash Core Team Foundation Member Masternode Owner/Operator Moderator

    Joined:
    Apr 9, 2014
    Messages:
    8,964
    Likes Received:
    6,736
    Trophy Points:
    1,283
    you gotta set the time longer than !
    120 ... 240 ....>>
     
  3. Kong

    Kong Member

    Joined:
    Apr 9, 2014
    Messages:
    55
    Likes Received:
    15
    Trophy Points:
    48
    I tried the function with 99999, 600, 900
     
    • Like Like x 1
  4. tungfa

    tungfa Administrator
    Dash Core Team Foundation Member Masternode Owner/Operator Moderator

    Joined:
    Apr 9, 2014
    Messages:
    8,964
    Likes Received:
    6,736
    Trophy Points:
    1,283
    Lets wait for the Tech Pros to come online .....>
     
  5. Kong

    Kong Member

    Joined:
    Apr 9, 2014
    Messages:
    55
    Likes Received:
    15
    Trophy Points:
    48
    I enjoy betting at directbet.eu with darkcoins. But it sucks that i have to put in my password for every single bet. I think that it is a bug in the "walletpassphrase" function. If anyone can try to reproduce this odd behavior of the function, than it should be no problem for evan to fix this bug. The priority should be that the wallet is useable now. There are a lot of people using Darkcoin right now, and in my opinion the basic wallet functions should work perfectly before trying to add new features to the coin like instantx. One thing after an other.
     
    • Like Like x 1
  6. Dr.Crypto

    Dr.Crypto Member

    Joined:
    Jul 9, 2014
    Messages:
    46
    Likes Received:
    32
    Trophy Points:
    58
    Stupid question, but did you remove the brackets when entering the command walletpassphrase <passphrase> <timeout> ?
    Like
    Code:
    walletpassphrase thisismypassphrase 120
    and not
    Code:
    walletpassphrase <thisismypassphrase> <120>
     
  7. moli

    moli Grizzled Member

    Joined:
    Aug 5, 2014
    Messages:
    3,261
    Likes Received:
    1,837
    Trophy Points:
    1,183
    There was another similar complaint like your complaint here:
    https://darkcointalk.org/threads/onyx-v3-10-17.3141/page-4#post-32487

    And here's the answer to it:
    https://darkcointalk.org/threads/onyx-v3-10-17.3141/page-5#post-32548

    Edit: And here's another answer also from UdjinM6:
    https://darkcointalk.org/threads/onyx-v3-10-17.3141/page-5#post-32552

    I haven't bothered to test the encryption on v.10.17.xx because the windows wallet versions are too bloated, not going to test encryption until a better version.
     
    #7 moli, Dec 12, 2014
    Last edited by a moderator: Dec 12, 2014
  8. Kong

    Kong Member

    Joined:
    Apr 9, 2014
    Messages:
    55
    Likes Received:
    15
    Trophy Points:
    48
    So does that mean that it stays like it is? This is not userfriendly... So i have to make my bets with litecoins....
     
  9. oblox

    oblox Well-known Member

    Joined:
    Aug 6, 2014
    Messages:
    1,032
    Likes Received:
    537
    Trophy Points:
    183
    Did you try Darkcoil (stripped down version without DS)?
     
  10. Kong

    Kong Member

    Joined:
    Apr 9, 2014
    Messages:
    55
    Likes Received:
    15
    Trophy Points:
    48
    Is the wallet.dat from the original wallet compatible with this new wallet?
     
  11. oblox

    oblox Well-known Member

    Joined:
    Aug 6, 2014
    Messages:
    1,032
    Likes Received:
    537
    Trophy Points:
    183
    https://darkcointalk.org/threads/darkcoil-lightweight-darkcoin-wallet-v0-9-17-19.3017/

    Should be since it was built from an older branch. Besides, if you have a duplicate wallet file, if it corrupts, it's not the end of the world. Always have backups. I haven't personally used Darkcoil but it might be worth trying in your case.

    Also, doing a secondary wallet.dat with no password might be an alternative direction to go. Specify the return payouts either to that address for when you have it open or your primary with the password and then send what you want to bet to this new, password-free wallet, loading it, and betting from there.
     
  12. UdjinM6

    UdjinM6 Official Dash Dev
    Dash Core Team Moderator

    Joined:
    May 20, 2014
    Messages:
    3,637
    Likes Received:
    3,536
    Trophy Points:
    1,183
    Hello everyone and than you moli for pointing to my previous answers. :)

    Yep, that is how it works now. I know it's confusing, sorry about that.:oops:
    This anonymizeonly feature was made in hurry to let people mix coins while staying more or less safe at the same time so it's not ideal...

    I actually found a way to make logic work in more expectable way (I hope), already implemented this logic in my repo and made few test, it seems to work fine. Should be like this: wallet will request "unlock for sending" only if it was "locked" or "unlocked for mixing only" before opening confirmation dialog on sending coins. This way users will be able to unlock by issuing walletpassphrase command or by using menu ("Unlock") and make as many transactions as they need until walletpassphrase timeout / manual locking / closing their wallet. At the same time unlocking during the process of sending coins will lock wallet back again immediately.

    However dev team is busy right now moving whole Darkcoin code base from litecoin 0.8 to bitcoin 0.9.3. This will bring a lot of internal optimizations and new features from bitcoin core, should fix old problems with stuck syncing also, etc. A lot of work was already done by vertoe and now eduffield is pushing hard but there are still a lot of things left to do. Not to say about testing and hunting new bugs;). So I'm not sure if there will be another compiled version on our old branch (most likely no) but similar patch will be included in new code base in next release I guess.

    EDIT:
    PS. It's 10 in the morning, I'm going to have some sleep... finally... I love working in the Dark :D...
     
    #12 UdjinM6, Dec 12, 2014
    Last edited by a moderator: Dec 12, 2014
    • Like Like x 2
  13. UdjinM6

    UdjinM6 Official Dash Dev
    Dash Core Team Moderator

    Joined:
    May 20, 2014
    Messages:
    3,637
    Likes Received:
    3,536
    Trophy Points:
    1,183
    Well, I was wrong about compiled version ;)

    https://bitcointalk.org/index.php?topic=421615.msg9847407#msg9847407

    The cool thing is that while moving to bitcoin 0.9.3 we were still patching DarkCoin 0.10.17.x so making an urgent update brings all recent bugfixes/features too :cool:
    Give it a try and see how it works.
    Waiting for your replies...:rolleyes:
     
  14. vertoe

    vertoe Three of Nine

    Joined:
    Mar 28, 2014
    Messages:
    2,573
    Likes Received:
    1,652
    Trophy Points:
    1,283
    Fixing in which direction? From .11 to .10?
     
  15. UdjinM6

    UdjinM6 Official Dash Dev
    Dash Core Team Moderator

    Joined:
    May 20, 2014
    Messages:
    3,637
    Likes Received:
    3,536
    Trophy Points:
    1,183
  16. vertoe

    vertoe Three of Nine

    Joined:
    Mar 28, 2014
    Messages:
    2,573
    Likes Received:
    1,652
    Trophy Points:
    1,283
  17. UdjinM6

    UdjinM6 Official Dash Dev
    Dash Core Team Moderator

    Joined:
    May 20, 2014
    Messages:
    3,637
    Likes Received:
    3,536
    Trophy Points:
    1,183
    Ahh... 2 of them are mine - I made PRs to both branches and they are merged, freynder made the same and it's merged too afaik. DoS fix was already there by eduffield I believe.
    The latest payment fix is still to be implemented in 0.11 though.

    Evan replied https://bitcointalk.org/index.php?topic=421615.msg9850101#msg9850101 and he said in private chat that Mr.Spread didn't reach him with any new bugs yet.