v0.10.17 - Onyx v3

eduffield

Core Developer
Mar 9, 2014
1,084
5,320
183
Onyx v3 Release - 10.17.23

Many improvements are included:
- Fix for the "dead change" issue (https://darkcointalk.org/threads/dead-change-an-anonymity-issue.3019/). This was fixed by adding a 0.1DRK denomination and having the client overpay by an average of 0.05DRK when transacting anonymously. This eliminates change, which causes the vulnerability and allows for far greater anonymity.
- Removed the 500DRK denomination.
- Replaced the 3 option payment combobox with a "Darksend" checkbox.
- Darksend "unlock only to anonymize" feature (UdjinM6)


Other DOS vulnerability fixes:
- Darksend Outputs/Collateral Outputs payment scripts are now checked to make sure they're normal
- Collateral now checked for nLockTime
- Masternode list can only be requested once per IP per day now

Memory bandwidth improvements
- Darksend transactions are now sent headers first and full data is requested once (saving up to 90% bandwidth)
- Masternode pings are now much more efficiently broadcast to the network

Who should update? Everyone!

Thanks to UdjinM6 and Flare for help with debugging and development. Also thanks to everyone who helped test and find all of the bugs! You guys are awesome!

--

Downloads

10.17.26 Onyx V3 - All Users

Source: https://github.com/darkcoin/darkcoin
Windows .exe: https://github.com/darkcoinproject/darkcoin-binaries/raw/master/darkcoin-0.10.17.26-win.zip
Mac OSX: https://github.com/darkcoinproject/darkcoin-binaries/raw/master/darkcoin-0.10.17.26-osx.dmg
Linux: https://github.com/darkcoinproject/darkcoin-binaries/raw/master/darkcoin-0.10.17.26-linux.tar.gz

Change Log

10.17.21
- fixed dsee fake-signing vulnerability & reduced spam logging

10.17.22
- Allow new dsee broadcasts to overwrite existing addresses of masternodes
- Fixed broken unit tests
- Fixed P2Pool connectivity issues (minprotocol = 70043 now)

10.17.23
- Fixed a minor DSEEP vulnerability

10.17.24
- Fixed possible masternode payments exploit

10.17.25/26
- Fixed bugs with Start-many
- Fixed an issue where clients might not be able to validate a block and get stuck
 
Last edited by a moderator:

Minotaur

Well-known Member
Foundation Member
Apr 7, 2014
452
1,079
263
Is there backward compatibility so that masternodes in the previous version will continue to get paid as the network updates, for a few days?
 
  • Like
Reactions: Dr.Crypto

moli

Grizzled Member
Aug 5, 2014
3,255
1,830
1,183
I'm still testing this version on Testnet before using it on Mainnet. Anyone else is on Testnet? 2000, 8 rounds here.
 

thelonecrouton

Well-known Member
Foundation Member
Apr 15, 2014
1,135
813
283
I love the smell of SMUT and protocol bumps early in the morning. 4:46am and all updated.
 

oblox

Well-known Member
Aug 6, 2014
1,032
537
183
Is there backward compatibility so that masternodes in the previous version will continue to get paid as the network updates, for a few days?
Considering enforcement is still on and suchpool (already updated) paid a 10.16.16, I'd say yes. I believe Evan allows older protocols in this release for a week or something to give people time to update.
 

crowning

Well-known Member
May 29, 2014
1,415
1,997
183
Alpha Centauri Bc
BUG: Win7 wallet, v0.10.17.19, deleted peers.dat before start, -rescan:

Assertion.jpg

End of debug.log:
Code:
2014-12-05 07:52:21 CheckBlock() : Skipping masternode payment check - nHeight 180914 Hash 00000000000c5508aaabd8c2dc567e0d4bf988c99eaf7ac9bda8e6addc6ec4d3
2014-12-05 07:52:21 CheckBlock() : Skipping masternode payment check - nHeight 180914 Hash 000000000001c81707ce63ceccaa33407611222974df8596d691e81eae93d9d8
2014-12-05 07:52:21 No coin database inconsistencies in last 289 blocks (790 transactions)
2014-12-05 07:52:21  block index  14481ms
2014-12-05 07:52:24 nFileVersion = 101719
2014-12-05 07:52:24  wallet  2328ms
2014-12-05 07:52:24 Rescanning last 180913 blocks (from block 0)...
2014-12-05 07:52:24  rescan  1ms
Edit: happened with v0.10.16.16 as well, but disappeared after a Windows restart. So, until further evidence, I label this as Windows hickup....
 
Last edited by a moderator:
  • Like
Reactions: flare

camosoul

Grizzled Member
Sep 19, 2014
2,261
1,130
1,183
Start-many appears to be broken... Declares "capable masternode" in debug.log, but does not announce. Network is never aware. Never appear in masternode list.

"Started X, Failed X, total X" message never appears. All else appears as it normally would...
 
Last edited by a moderator:

yidakee

Well-known Member
Foundation Member
Apr 16, 2014
1,812
1,168
283
Start-many appears to be broken... Declares "capable masternode" in debug.log, but does not announce. Network is never aware. Never appear in masternode list.

"Started X, Failed X, total X" message never appears in debug.log. All else appears as it normally would...
Camo, this feature is still highly experimental and hasn't been looked at for a while. It is highly advised not to used it. This caused you massive grief last time, why do it again?

.
 

camosoul

Grizzled Member
Sep 19, 2014
2,261
1,130
1,183
[edited to show conclusion instead of process of discovery]

start-many has been cut-off from the announcement call. I ain't juggling money in a tornado when this such an easy thing to fix, and I',m even willing to pay to get it done if nobody else can see how important it is.
 
Last edited by a moderator:

splawik21

Grizzled Member
Dash Core Team
Moderator
Foundation Member
Dash Support Group
Apr 8, 2014
1,929
1,286
1,283
@ this ver i see that the wallet gets locked after sending funds, this bug has been fixed...excellent!
 

camosoul

Grizzled Member
Sep 19, 2014
2,261
1,130
1,183
Nodes offline until broadcast/announce bug and fragmentation are fixed.

My guess is that the changes related to making MNs more pingable, somehow islanded the announce call from start-many. Start-many does all it's stuff, but calls the announcement and the name of that process has changed. It's untrapped, so no output except telling me that all is well while it does nothing instead.

No idea why I'm seeing shards tho...
 
Last edited by a moderator:

Light

Well-known Member
Foundation Member
Jun 4, 2014
346
256
233
This happens when clicked MAC OSX (same problem also in Darkcoin.io website download section)

EDIT: False alarm! It works now :)

 

crowning

Well-known Member
May 29, 2014
1,415
1,997
183
Alpha Centauri Bc
  • Like
Reactions: Raico

camosoul

Grizzled Member
Sep 19, 2014
2,261
1,130
1,183
2000 DRK anon limit still present. Was unclear if this was a temporary thing for testnet, or intended to be part of this release...
 

crowning

Well-known Member
May 29, 2014
1,415
1,997
183
Alpha Centauri Bc
Perfect! Can you lower the update time to 15mins until drk.mn has been updated?
Done. I'll leave it at that for the rest of the day.

I'll change it back to 60 minutes once the network is stable again, because I fear the geo-location provider will ban me when I create too much traffic.

I had to switch the provider already 3x....
 
  • Like
Reactions: flare

flare

Administrator
Dash Core Team
Moderator
May 18, 2014
2,286
2,404
1,183
Germany
Done. I'll leave it at that for the rest of the day.

I'll change it back to 60 minutes once the network is stable again, because I fear the geo-location provider will ban me when I create too much traffic.

I had to switch the provider already 3x....
Maybe you can create a stripped down version, just showing the IPs without geolocation ;)
 

freynder

New Member
Dec 5, 2014
30
63
18
Nodes offline until broadcast/announce bug and fragmentation are fixed.

My guess is that the changes related to making MNs more pingable, somehow islanded the announce call from start-many. Start-many does all it's stuff, but calls the announcement and the name of that process has changed. It's untrapped, so no output except telling me that all is well while it does nothing instead.

No idea why I'm seeing shards tho...
I can confirm this, had the same problem. Had nothing but issues so far using start-many so I decided to move the funds to seperate wallets again.

I intend to review the code next week and submit a pull request for better start-many support. I'm thinking of adding the transaction and output index as a parameter for each masternode in masternode.conf so that one can manage each vin and associated masternode individually from the same wallet. Individual masternodes could then also be started/stopped from the same wallet. Any feedback is appreciated.