Welcome to the Dash Forum!

Please sign up to discuss the most innovative cryptocurrency!

Travis integration

Discussion in 'Official Developer Thread' started by crowning, Jan 11, 2016.

  1. crowning

    crowning Official Dash Dev
    Core Developer Moderator

    Joined:
    May 29, 2014
    Messages:
    1,430
    Likes Received:
    2,009
    Trophy Points:
    183
    I've just created a pull-request for Bitcoin (I know, I know...but I couldn't resist [​IMG]) and like the way the changes are immediately tested/build over at https://travis-ci.org/.

    I'd like to have this for Dash as well...and it's free. Thoughts?
    eduffield , flare ? Shall I do it?

    Clipboard01.jpg


    Details:
    Clipboard02.jpg
     
    • Like Like x 5
  2. flare

    flare Administrator
    Dash Core Team Moderator

    Joined:
    May 18, 2014
    Messages:
    2,287
    Likes Received:
    2,426
    Trophy Points:
    1,183
    I am with you, just had no time yet to dig into Travis :)
     
    • Like Like x 1
  3. flare

    flare Administrator
    Dash Core Team Moderator

    Joined:
    May 18, 2014
    Messages:
    2,287
    Likes Received:
    2,426
    Trophy Points:
    1,183
    • Like Like x 1
  4. crowning

    crowning Official Dash Dev
    Core Developer Moderator

    Joined:
    May 29, 2014
    Messages:
    1,430
    Likes Received:
    2,009
    Trophy Points:
    183
    Thanks.

    I guess ".travis.yml" needs some love. If I'd find some time next weekend I'll have a look.

    Edit: yep, log says the tests are run which fail for Dash of course. The individual builds overwrite RUN_TESTS=false. Should be an easy fix. I'll do it later today.
     
    #4 crowning, Jan 12, 2016
    Last edited by a moderator: Jan 12, 2016
  5. flare

    flare Administrator
    Dash Core Team Moderator

    Joined:
    May 18, 2014
    Messages:
    2,287
    Likes Received:
    2,426
    Trophy Points:
    1,183
    Disabling the tests is not a fix though :)
     
    • Like Like x 1
  6. crowning

    crowning Official Dash Dev
    Core Developer Moderator

    Joined:
    May 29, 2014
    Messages:
    1,430
    Likes Received:
    2,009
    Trophy Points:
    183
    Almost there:

    Clipboard01.jpg

    I'll have another look later (or tomorrow) for the one failing build and create pull-requests once it's ready to merge.
     
  7. flare

    flare Administrator
    Dash Core Team Moderator

    Joined:
    May 18, 2014
    Messages:
    2,287
    Likes Received:
    2,426
    Trophy Points:
    1,183
  8. crowning

    crowning Official Dash Dev
    Core Developer Moderator

    Joined:
    May 29, 2014
    Messages:
    1,430
    Likes Received:
    2,009
    Trophy Points:
    183
    I know, but a first step must be to be able to replicate what Atlassian does, but automatically for each commit.

    Fixing the tests for Dash is a different task, I think I had once start to fix some just to learn that it's not trivial to get all tests running.

    BTW, Travis is not always reliable, I just re-run my repository-build and some builds failed (couldn't wget qrencode-3.4.3.tar.bz2, another build couldn't wget the Mac SDK, ...). Worked before without any problems...
     
  9. flare

    flare Administrator
    Dash Core Team Moderator

    Joined:
    May 18, 2014
    Messages:
    2,287
    Likes Received:
    2,426
    Trophy Points:
    1,183
    I have found the root cause for the wget problems: wget on precise (which we are using on Travis) is outdated and not able to connect to SSLv3 enabled sites.

    I have worked around this by using curl (see https://github.com/travis-ci/travis-ci/issues/5156)

    So at least the testless ARM and MacOSX builds are green now, and I have made good progress on the failing tests for the other platforms - only 245 failing tests to go :)

    upload_2016-1-27_14-44-23.png

    We are getting there :)

    upload_2016-1-27_15-4-52.png
     
    • Like Like x 2
  10. crowning

    crowning Official Dash Dev
    Core Developer Moderator

    Joined:
    May 29, 2014
    Messages:
    1,430
    Likes Received:
    2,009
    Trophy Points:
    183
    Very good [​IMG] :)

    I'll merge/add this to my own Travis-branch and see what else is needed.
     
    • Like Like x 1
  11. crowning

    crowning Official Dash Dev
    Core Developer Moderator

    Joined:
    May 29, 2014
    Messages:
    1,430
    Likes Received:
    2,009
    Trophy Points:
    183
    Slooooowly getting there:
    Travis.jpg
     
  12. flare

    flare Administrator
    Dash Core Team Moderator

    Joined:
    May 18, 2014
    Messages:
    2,287
    Likes Received:
    2,426
    Trophy Points:
    1,183
  13. crowning

    crowning Official Dash Dev
    Core Developer Moderator

    Joined:
    May 29, 2014
    Messages:
    1,430
    Likes Received:
    2,009
    Trophy Points:
    183
    Code:
    if [ -n "$OSX_SDK" -a -f depends/sdk-sources/MacOSX${OSX_SDK}.sdk.tar.gz ]; then tar -C depends/SDKs -xf depends/sdk-sources/MacOSX${OSX_SDK}.sdk.tar.gz; fi
    
    tar: This does not look like a tar archive
    
    I can't access https://dash.org/depends-sources/sdks, so I don't know what's in there.
     
  14. flare

    flare Administrator
    Dash Core Team Moderator

    Joined:
    May 18, 2014
    Messages:
    2,287
    Likes Received:
    2,426
    Trophy Points:
    1,183
    The path structure did not change, so https://dash.org/depends-sources/sdks/MacOSX10.7.sdk.tar.gz works

    edit:

    Down to 234 failures :)

    [​IMG]

    https://travis-ci.org/dashpay/dash/jobs/105368611#L4806
     
    #14 flare, Jan 28, 2016
    Last edited by a moderator: Jan 28, 2016
  15. flare

    flare Administrator
    Dash Core Team Moderator

    Joined:
    May 18, 2014
    Messages:
    2,287
    Likes Received:
    2,426
    Trophy Points:
    1,183
    :D

    upload_2016-1-29_17-43-3.png
     
    • Like Like x 2
  16. flare

    flare Administrator
    Dash Core Team Moderator

    Joined:
    May 18, 2014
    Messages:
    2,287
    Likes Received:
    2,426
    Trophy Points:
    1,183
    All tests pass now, currently wrapping it up :)

    upload_2016-1-30_13-36-40.png
     
    • Like Like x 2
  17. crowning

    crowning Official Dash Dev
    Core Developer Moderator

    Joined:
    May 29, 2014
    Messages:
    1,430
    Likes Received:
    2,009
    Trophy Points:
    183
    Excellent :)

    So I guess you'll merge it into v0.12.0.56 and v0.12.1.x and I can delete my Travis-test repository?
     
  18. flare

    flare Administrator
    Dash Core Team Moderator

    Joined:
    May 18, 2014
    Messages:
    2,287
    Likes Received:
    2,426
    Trophy Points:
    1,183
    Yep, I'll merge it, PR was tested OK ;)

    upload_2016-1-30_14-52-14.png
     
    • Like Like x 1
  19. flare

    flare Administrator
    Dash Core Team Moderator

    Joined:
    May 18, 2014
    Messages:
    2,287
    Likes Received:
    2,426
    Trophy Points:
    1,183
    upload_2016-1-30_15-44-4.png

    crowning: Thanks for bringing this back to my attention, i wanted to have this since ages :)
     
  20. TaoOfSatoshi

    TaoOfSatoshi Grizzled Member
    Linguistic Dash Nation Founder Moderator

    Joined:
    Jul 15, 2014
    Messages:
    2,552
    Likes Received:
    2,552
    Trophy Points:
    1,183
    Is Travis better than GitHub? Will you be using this now instead of GitHub?
     
  21. crowning

    crowning Official Dash Dev
    Core Developer Moderator

    Joined:
    May 29, 2014
    Messages:
    1,430
    Likes Received:
    2,009
    Trophy Points:
    183
    Travis is an addition to GitHub, no replacement. You just have to assign a GitHub repository in Travis, and whenever new code is committed into your repository Travis automatically builds and tests it so you can easily see when something is broken without having to build it yourself all the time.

    Saves us developers a ton of time.
     
    • Like Like x 2
  22. TaoOfSatoshi

    TaoOfSatoshi Grizzled Member
    Linguistic Dash Nation Founder Moderator

    Joined:
    Jul 15, 2014
    Messages:
    2,552
    Likes Received:
    2,552
    Trophy Points:
    1,183
    Oh that's great! Efficiency is good...
    EDIT:
    Woot!
    https://twitter.com/taoofsatoshi/status/693578685648101377
     
    #22 TaoOfSatoshi, Jan 30, 2016
    Last edited by a moderator: Jan 30, 2016
  23. Davide Print

    Davide Print New Member

    Joined:
    Apr 30, 2018
    Messages:
    1
    Likes Received:
    0
    Trophy Points:
    1
  24. icoselector18

    icoselector18 New Member

    Joined:
    Mar 9, 2018
    Messages:
    6
    Likes Received:
    0
    Trophy Points:
    1

Share This Page