Welcome to the Dash Forum!

Please sign up to discuss the most innovative cryptocurrency!

Temporary disabling of InstandSend due to potential quorum exploit method

Discussion in 'Official Announcements' started by AndyDark, Aug 30, 2017.

  1. tungfa

    tungfa Administrator
    Dash Core Team Foundation Member Masternode Owner/Operator Moderator

    Joined:
    Apr 9, 2014
    Messages:
    8,567
    Likes Received:
    6,600
    Trophy Points:
    1,283
    IS will be back on when 12.2 is released

    otho ?
    what does otho has to do with this

    save to use
    it is disabled so there is nothing to use
     
  2. solarguy

    solarguy Active Member

    Joined:
    Mar 15, 2017
    Messages:
    776
    Likes Received:
    343
    Trophy Points:
    133

    When they turn it on again, it will be safe to use.
     
  3. dark_wanderer

    dark_wanderer Member

    Joined:
    Nov 12, 2014
    Messages:
    82
    Likes Received:
    35
    Trophy Points:
    58
    Thanks for the feedback.

    Could you also please answer the following questions with yes/no?

    1) Has the fix been completed and qa'ed on 30 sep 2017?
    2) Is work on the fix still in progress as of 24 sep 2017?
    3) Is work on the fix still in progress as of today?
     
  4. dark_wanderer

    dark_wanderer Member

    Joined:
    Nov 12, 2014
    Messages:
    82
    Likes Received:
    35
    Trophy Points:
    58
    sorry, the first question should have been:

    1) Has the fix been completed and qa'ed on 30 aug 2017?
     
  5. thedesertlynx

    thedesertlynx Active Member

    Joined:
    Sep 6, 2016
    Messages:
    142
    Likes Received:
    131
    Trophy Points:
    93
    Hi @AndyDark, any update on 12.2? It's been nearly a month since this original post, and InstantSend being disabled has prevented a number of projects from continuing development. In general, it's just good to know what to tell people when they ask when they'll be able to use InstantSend again. Thanks!
     
    • Like Like x 1
    • Agree Agree x 1
  6. Johnmark1845

    Johnmark1845 New Member

    Joined:
    Sep 27, 2017
    Messages:
    1
    Likes Received:
    0
    Trophy Points:
    1
    same question.
     
  7. UdjinM6

    UdjinM6 Official Dash Dev
    Dash Core Team Moderator

    Joined:
    May 20, 2014
    Messages:
    3,612
    Likes Received:
    3,516
    Trophy Points:
    1,183
    • Informative Informative x 3
  8. thedesertlynx

    thedesertlynx Active Member

    Joined:
    Sep 6, 2016
    Messages:
    142
    Likes Received:
    131
    Trophy Points:
    93
    Yes, that was well understood. What I'm not entirely clear about is when the release is planned. The roadmap said September.

    I realize that this is a complicated problem that I'm glad I don't have to handle, it just puts me in a difficult position when newcomers ask about when they can use InstantSend and I don't have an answer. It reflects poorly on Dash and makes it seem like things are broken and a mess, and while I know that such isn't true at all, I'd like to be able to answer that question with confidence.
     
    • Like Like x 1
  9. UdjinM6

    UdjinM6 Official Dash Dev
    Dash Core Team Moderator

    Joined:
    May 20, 2014
    Messages:
    3,612
    Likes Received:
    3,516
    Trophy Points:
    1,183
    The roadmap was put together before IS issue was even discovered and it took a lot of time to find a proper way to fix it (initially we had another fix prepared btw). Anyway, all major tickets for 12.2 are closed now and everything (2mb blocks, lower fees, IS fix, and a whole bunch of internal fixes/backports/refactoring) seems to be working as designed. We are forking testnet right now to test migration process and to make sure that we didn't miss anything and dip0001 activation + network upgrade work well together (these were two separate events on "old" testnet). That's going to take few more days, not sure how long but at least 3 more. If no issues are found during this, then we are going to start migration at the very end of September (30th) or first days of October (more likely). Then it depends on how fast masternoders/miners are going to update so that dip0001 could lock in/activate and thus trigger other fixes. However, you should keep in mind that dip0001 lock in is going to require at least a week in any case, see https://github.com/dashpay/dips/blob/master/dip-0001.md#selection-of-parameters and _this_ is the earliest time we can turn IS back on. Considering how long it usually takes to update MNs, I'd say this day (of IS activation) is probably closer to mid of October.
     
    • Informative Informative x 3
    • Like Like x 1
    • Agree Agree x 1
    • Winner Winner x 1
  10. thedesertlynx

    thedesertlynx Active Member

    Joined:
    Sep 6, 2016
    Messages:
    142
    Likes Received:
    131
    Trophy Points:
    93
    Thanks for the detailed response, this is definitely something I can work with.

    Question: in the original post, Andy mentioned the possibility of an immediate hotfix instead of waiting for 12.2. What would have been the timeline for this approach from the moment the problem was announced?
     
  11. AjM

    AjM Well-known Member
    Foundation Member Masternode Owner/Operator

    Joined:
    Jun 23, 2014
    Messages:
    1,299
    Likes Received:
    564
    Trophy Points:
    283
    And translations?
    Who and when?
     
  12. UdjinM6

    UdjinM6 Official Dash Dev
    Dash Core Team Moderator

    Joined:
    May 20, 2014
    Messages:
    3,612
    Likes Received:
    3,516
    Trophy Points:
    1,183
    It's hard to tell. That fix would include protocol bump to get some idea of update progress which would mean that everyone would have to update and moreover, MNs would have to be restarted losing their place in the payment queue.. which is quite of a disincentive. Generally speaking, that would be just like any other major update (we would probably had to turn payment enf. off too because moving MNs in and out of the list brings some "turbulence" to network, which can result in forking). So I'd say it would take at least 2-3 weeks before things would calm down (we fixed this and it shouldn't cause that many issues for 12.2+ updates btw, well, hopefully :rolleyes:). This means that it would be mid/end of September, when we could activate IS... and then we'd have to turn it off again for 12.2 migration after a week or so and ask everyone to update once again... so it didn't make much sense to follow that path imo.

    I hate this part :p I'll upload new _en.ts to transifex in a few following days. This usually doesn't break anything and can be updated even later in some minor releases, so I left this part for the very end of testing.
     
    • Like Like x 1
    • Agree Agree x 1
  13. AjM

    AjM Well-known Member
    Foundation Member Masternode Owner/Operator

    Joined:
    Jun 23, 2014
    Messages:
    1,299
    Likes Received:
    564
    Trophy Points:
    283
    Ok, thanks.
     
    • Like Like x 1
  14. akhavr

    akhavr Active Member
    Masternode Owner/Operator

    Joined:
    Oct 11, 2014
    Messages:
    617
    Likes Received:
    330
    Trophy Points:
    133
    Is there a slack channel, that I can join in, and put a node on a testnet?
     
  15. thedesertlynx

    thedesertlynx Active Member

    Joined:
    Sep 6, 2016
    Messages:
    142
    Likes Received:
    131
    Trophy Points:
    93
    Very good, thank you, that fully answers the whole subject. I think this excellent level of communication is just what's needed to mitigate misconceptions held by the general public. Highly anticipating the 12.2 release!
     
  16. wal

    wal New Member

    Joined:
    Dec 6, 2016
    Messages:
    30
    Likes Received:
    12
    Trophy Points:
    8
    >However, for safety we have disabled InstandSend via ["SPORK_2_INSTANTSEND_ENABLED": false]

    Can you elaborate on that? What else on the DASH network can be enabled/disabled by the powers-to-be ?
     
  17. Ch0nG

    Ch0nG Member

    Joined:
    Oct 3, 2014
    Messages:
    52
    Likes Received:
    34
    Trophy Points:
    58
  18. wal

    wal New Member

    Joined:
    Dec 6, 2016
    Messages:
    30
    Likes Received:
    12
    Trophy Points:
    8
  19. Ronduitfantastisch

    Ronduitfantastisch New Member

    Joined:
    Feb 4, 2017
    Messages:
    1
    Likes Received:
    0
    Trophy Points:
    1
    Is there any thinking about how the masternodes can be involved by turning off IS or other features?
     
  20. thedesertlynx

    thedesertlynx Active Member

    Joined:
    Sep 6, 2016
    Messages:
    142
    Likes Received:
    131
    Trophy Points:
    93
    I hear that's being looked into for the future.
     
    • Like Like x 1
  21. UdjinM6

    UdjinM6 Official Dash Dev
    Dash Core Team Moderator

    Joined:
    May 20, 2014
    Messages:
    3,612
    Likes Received:
    3,516
    Trophy Points:
    1,183
    Took me longer than I expected exactly because of the reasons why I hate it - some packages for python scripts were missing and I broke my env trying to fix it.. Anyway, en source should be more or less up to date on transifex now :)

    Note/reminder to everyone translating strings:
    - please keep all special symbols in place - %n and %1 etc are placeholders and MUST be kept ("Copy source string" button is your friend);
    - keep number of brackets the same, make sure you have (no) "." at the end just like in the original source;
    - do not translate Dash (Core), translating "dashes" is ok however;
    - use "Suggestions" to follow more or less the same terminology and save your time;
    - you can "borrow" translations for some strings from bitcoin https://github.com/bitcoin/bitcoin/tree/master/src/qt/locale , they are far from being accurate sometimes but can serve as a good start;
    - probably smth else I can't remember right now, we'll figure it out as we progress :)

    EDIT: PR created https://github.com/dashpay/dash/pull/1659
     
    #51 UdjinM6, Sep 30, 2017
    Last edited: Sep 30, 2017
  22. AjM

    AjM Well-known Member
    Foundation Member Masternode Owner/Operator

    Joined:
    Jun 23, 2014
    Messages:
    1,299
    Likes Received:
    564
    Trophy Points:
    283
    Ok, thanks.
    How much we have time to get it done?

    EDIT: Finnish translated. There was only 76 new strings.
     
    #52 AjM, Sep 30, 2017
    Last edited: Sep 30, 2017
    • Like Like x 1
  23. UdjinM6

    UdjinM6 Official Dash Dev
    Dash Core Team Moderator

    Joined:
    May 20, 2014
    Messages:
    3,612
    Likes Received:
    3,516
    Trophy Points:
    1,183
    • Agree Agree x 1
    • Friendly Friendly x 1
  24. shravanivanteru

    shravanivanteru New Member

    Joined:
    Oct 26, 2017
    Messages:
    3
    Likes Received:
    2
    Trophy Points:
    3
    Nice, Great work
     

Share This Page