Welcome to the Dash Forum!

Please sign up to discuss the most innovative cryptocurrency!

Mixing doesn't work on 12.1?

Discussion in 'PrivateSend Questions and Help' started by traveling289, Feb 18, 2017.

  1. traveling289

    traveling289 New Member

    Joined:
    Feb 18, 2017
    Messages:
    7
    Likes Received:
    2
    Trophy Points:
    3
    Hi there,

    I upgraded my wallet, that seemed to work fine. Bought a couple dash and started mixing to see that it works on 12.1. After trying off and on for days, nothing is happening. Is mixing working since the upgrade?
     
  2. traveling289

    traveling289 New Member

    Joined:
    Feb 18, 2017
    Messages:
    7
    Likes Received:
    2
    Trophy Points:
    3
    Hmmm, radio silence, even with > 30 views. Am I the only one experiencing this problem?
     
  3. oaxaca

    oaxaca Well-known Member
    Foundation Member

    Joined:
    Jul 8, 2014
    Messages:
    539
    Likes Received:
    832
    Trophy Points:
    263
    Can you post a screenshot of your wallet or your coincontrol or your transactions or something that would help diagnose it?
     
  4. traveling289

    traveling289 New Member

    Joined:
    Feb 18, 2017
    Messages:
    7
    Likes Received:
    2
    Trophy Points:
    3
    Ok, sure. See two files uploaded.
     

    Attached Files:

  5. AjM

    AjM Well-known Member
    Foundation Member Masternode Owner/Operator

    Joined:
    Jun 23, 2014
    Messages:
    1,106
    Likes Received:
    487
    Trophy Points:
    253
    I think your dash amount is too low, but not sure, ping @UdjinM6
     
  6. camosoul

    camosoul Well-known Member

    Joined:
    Sep 19, 2014
    Messages:
    1,381
    Likes Received:
    963
    Trophy Points:
    183
    Image 2 looks like mixing to me...
     
  7. traveling289

    traveling289 New Member

    Joined:
    Feb 18, 2017
    Messages:
    7
    Likes Received:
    2
    Trophy Points:
    3
    Ok, see attached. Looks like the problem is evident in there. Lots of entries like this:

    2017-02-22 00:56:12 CDarksendPool::CreateDenominated -- Error: Transaction amounts must be positive
    2017-02-22 00:56:12 keypool return 1202
    2017-02-22 00:56:12 CDarksendPool::CreateDenominated -- failed!
     

    Attached Files:

    • Like Like x 1
  8. UdjinM6

    UdjinM6 Official Dash Dev
    Core Developer Moderator

    Joined:
    May 20, 2014
    Messages:
    3,034
    Likes Received:
    3,093
    Trophy Points:
    1,183
    Indeed, that's the problem - you have only way too small inputs which are less than even the smallest denomination. This means that they can't be broken into denominations without merging them into a large input first and Dash Core 12.1+ will not longer do this automatically for you because this means linking previous inputs together i.e. damaging privacy and letting blockchain crawlers to put pieces together. If you still want these coins to be mixed and you don't care about linking previous inputs, you have to take care of that manually by picking such inputs using Coin Control and sending them to yourself.
     
  9. traveling289

    traveling289 New Member

    Joined:
    Feb 18, 2017
    Messages:
    7
    Likes Received:
    2
    Trophy Points:
    3
    Lol! Well okay, I appreciate you taking the time to investigate and respond. +1 For Dash community!

    However, not to be flip, but you must realize this is an highly technical response. I've been in the software industry for years my self, so hopefully I can figure this out, but if your team's real aim is to get beyond geeks and go mainstream like your polished marketing collateral says, stuff like this needs to "just work." PayPal and Visa have significant security issues too, but they would never impose their technical complexity on the user base over a transaction.

    Anyway, I'll take a look at your suggestions and see what I can do. Thanks.
     
    • Like Like x 1
    • Agree Agree x 1
  10. traveling289

    traveling289 New Member

    Joined:
    Feb 18, 2017
    Messages:
    7
    Likes Received:
    2
    Trophy Points:
    3
    Ok, I took a look and indeed my wallet was full of dozens of tiny inputs no greater than .1 Dash. I decided to consolidate them by sending a transaction to myself, so now I have one input with 2.61 Dash. I started mixing, 3 denominations were created then it stopped. After a while I checked the debug log and see the successful denominations, but then eventually similar errors to before:

    2017-02-25 13:41:29 CreateDenominated0 nValueLeft: 0.001643
    2017-02-25 13:41:29 keypool reserve 1251
    2017-02-25 13:41:29 CreateDenominated2: nOutputsTotal: 0, nValueLeft: 0.001643
    2017-02-25 13:41:29 CreateDenominated2: nOutputsTotal: 0, nValueLeft: 0.001643
    2017-02-25 13:41:29 CreateDenominated3: nOutputsTotal: 0, nValueLeft: 0.001643
    2017-02-25 13:41:29 CDarksendPool::CreateDenominated -- Error: Transaction amounts must be positive

    As far as I can tell mixing is broken in 12.1, and that seems like a pretty big deal since private send is the main feature of the currency. If you say the amount of 2.61 Dash is too small I would say:
    1) The application should give me feedback that is a problem and not just quietly throw errors and do nothing on the surface.
    2) 2.61 Dash may be small today, but it won't be for long at the rate Dash is appreciating. If at some point Dash become worth as much as Bitcoin is now (>$1,000 at the time of this writing) that would be pretty lousy to say $1,000 worth of Dash is too small to mix.

    One last remark is that the dozens of inputs I had were mostly from a single 2 Dash ShapeShift transaction that sent a series of inputs each no larger than .1 Dash, so if that's a problem for the wallet and/or network to manage, then there's a bigger problem here.

    It's not like I'm really all that concerned about the privacy of a couple Dash. I'm just trying to see if things work in 12.1, and it appears they don't. At least not with a modest sized wallet. I've uploaded a couple more log files if you're interested. (There's 2 because I stopped Dash, rename the original ".old", then restarted)

    Thanks.
     

    Attached Files:

    • Agree Agree x 1
  11. UdjinM6

    UdjinM6 Official Dash Dev
    Core Developer Moderator

    Joined:
    May 20, 2014
    Messages:
    3,034
    Likes Received:
    3,093
    Trophy Points:
    1,183
    1. agree
    2. actually, I guess you just found a bug, congrats :)
     
    • Like Like x 1
  12. demo

    demo Active Member

    Joined:
    Apr 23, 2016
    Messages:
    1,252
    Likes Received:
    105
    Trophy Points:
    133
    Dash Address:
    XnpT2YQaYpyh7F9twM6EtDMn1TCDCEEgNX
    PrivateSend will become more and more obsolete, or lets say dangerous and not safe to use, as long as Dash is now directly or indireclty connected to coinfirm.
     
    #13 demo, Feb 25, 2017
    Last edited: Feb 25, 2017
    • Agree Agree x 1
    • Disagree Disagree x 1
  13. UdjinM6

    UdjinM6 Official Dash Dev
    Core Developer Moderator

    Joined:
    May 20, 2014
    Messages:
    3,034
    Likes Received:
    3,093
    Trophy Points:
    1,183
    This is pure FUD. The bug has nothing to do with mixing process itself, it's the way inputs are tallied before mixing. Coinfirm has nothing to do with this bug or mixing process in general. Not a single line of code was written to make their job easier. Moreover, 12.1 has stronger privacy due to not linking previous inputs from different addresses when creating denominations and randomized session cool downs to make timing analysis harder.
     
    • Like Like x 1
  14. demo

    demo Active Member

    Joined:
    Apr 23, 2016
    Messages:
    1,252
    Likes Received:
    105
    Trophy Points:
    133
    Dash Address:
    XnpT2YQaYpyh7F9twM6EtDMn1TCDCEEgNX
    Of course coinfirm has nothing to do with this specific bug, but coinfirm is a "force" that is going against the idea of mixing coins.

    And as long as part of the core team seems to serve coinfirm, this is what spreads Fear, Uncertainty and Doubt.

    "No one can serve two masters. For you will hate one and love the other; "

    You cannot serve Coinfirm and PrivateSend at the same time. The one contradicts the other.
     
    • Dumb Dumb x 2
    • Agree Agree x 1
  15. UdjinM6

    UdjinM6 Official Dash Dev
    Core Developer Moderator

    Joined:
    May 20, 2014
    Messages:
    3,034
    Likes Received:
    3,093
    Trophy Points:
    1,183
    Congrats on your first "dumb" from me, you really made me tired of you now
     
    • Winner Winner x 3
    • Like Like x 2
    • Dumb Dumb x 1
  16. demo

    demo Active Member

    Joined:
    Apr 23, 2016
    Messages:
    1,252
    Likes Received:
    105
    Trophy Points:
    133
    Dash Address:
    XnpT2YQaYpyh7F9twM6EtDMn1TCDCEEgNX
    :(


    :confused:What this dumb refers to?
    Am I dumb when saying that some members of the core team serve Coinfirm?
    Or, am I dumb when saying that PrivateSend's and Coinfirm's goals contradict eachother?
    Mixing is flagged as risk in coinfirm , isnt it?
     
    #17 demo, Feb 25, 2017
    Last edited: Feb 26, 2017
    • Agree Agree x 1
  17. demo

    demo Active Member

    Joined:
    Apr 23, 2016
    Messages:
    1,252
    Likes Received:
    105
    Trophy Points:
    133
    Dash Address:
    XnpT2YQaYpyh7F9twM6EtDMn1TCDCEEgNX
    @UdjinM6
    "You" is plural, it refers to the core team and not to you personally. Is this misunderstanding that made you rate me as dumb? Please forgive me, I didnt mean that you as a person serve coinfirm. I believe that you are trying hard to provide a strong PrivateSend service for all the Dash community, and I understand very well that this task is not an easy one. But, as long as I stupidly think that some core members may serve coinfirm, I am giving you the dumb advice to watch your back.
     
  18. traveling289

    traveling289 New Member

    Joined:
    Feb 18, 2017
    Messages:
    7
    Likes Received:
    2
    Trophy Points:
    3
    Ok, yes, bugs in software are unavoidable at some point. Is there anything else I can do to help? File the bug in an issue tracker somewhere? Any other information that is helpful to resolve the issue?
     
  19. AjM

    AjM Well-known Member
    Foundation Member Masternode Owner/Operator

    Joined:
    Jun 23, 2014
    Messages:
    1,106
    Likes Received:
    487
    Trophy Points:
    253
  20. UdjinM6

    UdjinM6 Official Dash Dev
    Core Developer Moderator

    Joined:
    May 20, 2014
    Messages:
    3,034
    Likes Received:
    3,093
    Trophy Points:
    1,183
    I'm working on it. I made first attempt to fix it https://github.com/dashpay/dash/pull/1364 but it looks like there is smth else.
    I don't think there is anything you can help with, I guess I just need to cleanup some things first and re-think the process a bit and then implement it correctly. Half way there I'd say...
    Thanks for reporting and sorry for inconvinience! :)
     

Share This Page