Welcome to the Dash Forum!

Please sign up to discuss the most innovative cryptocurrency!

Masternode Operators: Sentinel Hotfix (Action Required)

Discussion in 'Official Announcements' started by nmarley, Oct 26, 2017.

  1. nmarley

    nmarley Administrator
    Dash Core Team Moderator

    Joined:
    Jun 28, 2014
    Messages:
    337
    Likes Received:
    408
    Trophy Points:
    133
    Dash Address:
    XdBKajV4g2wnpnAvvnV9dxwypQMfFHYWtp
    Masternode Owners: Today a proposal was submitted which our system didn't catch (comma in the decimal) and this broke Sentinel, which means watchdogs stopped being created. We have pushed a hotfix, but Masternode Operators must intervene in order to update Sentinel (unless using some auto-update system).

    To implement, simply move into your "sentinel" directory and run a git pull:

    Code:
    cd /path/to/sentinel/ && git pull
    Note: This is required or your Masternode will go offline!
    (edit: Apparently w/spork 14 off this isn't enforce, so crisis averted!)

    Thank you for your service to the community.
     
    #1 nmarley, Oct 26, 2017
    Last edited: Oct 26, 2017
    • Like Like x 8
    • Informative Informative x 2
    • Useful Useful x 1
  2. Solaso

    Solaso Member

    Joined:
    Aug 20, 2015
    Messages:
    134
    Likes Received:
    22
    Trophy Points:
    68
    cd sentinel && git pull only this? Without restart mn?
     
    • Like Like x 1
  3. nmarley

    nmarley Administrator
    Dash Core Team Moderator

    Joined:
    Jun 28, 2014
    Messages:
    337
    Likes Received:
    408
    Trophy Points:
    133
    Dash Address:
    XdBKajV4g2wnpnAvvnV9dxwypQMfFHYWtp
    Yes, since the cron job is (should be) set up to run every minute, this should fix itself on the next run.
     
    • Like Like x 1
  4. Lariondos

    Lariondos Well-known Member
    Foundation Member Masternode Owner/Operator

    Joined:
    Apr 8, 2014
    Messages:
    89
    Likes Received:
    61
    Trophy Points:
    158
    Yes, after a couple of minutes, your masternode will be enabled again.
     
  5. Obusco

    Obusco Official Dash Dev
    Core Developer

    Joined:
    Sep 23, 2016
    Messages:
    41
    Likes Received:
    53
    Trophy Points:
    58
    As you probably setup a crontab to execute every 5 min sentinel, when it got executed, it will execute with the last fix :)
     
  6. methusaleh

    methusaleh Member

    Joined:
    Mar 25, 2016
    Messages:
    61
    Likes Received:
    34
    Trophy Points:
    58
    I'm hosted with Moo so is this something that happens at his end via Dashman or will I need to do a start?
     
  7. flare

    flare Administrator
    Dash Core Team Moderator

    Joined:
    May 18, 2014
    Messages:
    2,287
    Likes Received:
    2,426
    Trophy Points:
    1,183
    Yes, just update Sentinel, no more actions needed.
     
    • Like Like x 1
  8. flare

    flare Administrator
    Dash Core Team Moderator

    Joined:
    May 18, 2014
    Messages:
    2,287
    Likes Received:
    2,426
    Trophy Points:
    1,183
    Moo has to act, nothing to be done on your side
     
  9. methusaleh

    methusaleh Member

    Joined:
    Mar 25, 2016
    Messages:
    61
    Likes Received:
    34
    Trophy Points:
    58
    Thanks Flare I owe you guys a pint sometime ;)
     
    • Like Like x 1
  10. KryptoTypek

    KryptoTypek New Member

    Joined:
    Oct 1, 2016
    Messages:
    19
    Likes Received:
    11
    Trophy Points:
    3
    Wow, checked DashNinja after the fix and 4000 masternodes out of approx. 4700 were inactive... it's crazy that such thing as a budget proposal can take down a wast majority of the masternode network... anyways thanks for the quick fix.
     
    • Agree Agree x 4
  11. flare

    flare Administrator
    Dash Core Team Moderator

    Joined:
    May 18, 2014
    Messages:
    2,287
    Likes Received:
    2,426
    Trophy Points:
    1,183
    Technically the nodes are not down, they just failed to vote on a watchdog object.

    As a sidenote: Dash 12.2 will not have watchdogs anymore, they are deprecated.
     
    • Like Like x 4
    • Winner Winner x 2
    • Informative Informative x 2
  12. c44c

    c44c New Member

    Joined:
    Sep 4, 2015
    Messages:
    9
    Likes Received:
    1
    Trophy Points:
    3
    Thanks for the update and info gentlemen! Cheers! :)
     
  13. Walter

    Walter Active Member
    Masternode Owner/Operator

    Joined:
    Jul 17, 2014
    Messages:
    229
    Likes Received:
    187
    Trophy Points:
    103
    Awesome job guys! :)
     
    • Like Like x 1
  14. Geert

    Geert New Member

    Joined:
    Aug 26, 2015
    Messages:
    23
    Likes Received:
    14
    Trophy Points:
    3
    I'm scared! Where's Evan? Can Evan come back?
     
    • Funny Funny x 1
  15. ericsammons

    ericsammons Active Member
    Masternode Owner/Operator

    Joined:
    Jan 1, 2016
    Messages:
    141
    Likes Received:
    488
    Trophy Points:
    113
    First of all, great work to all involved in catching and fixing this situation so quickly.

    But it does raise some questions. This seems similar to an SQL injection, in that a malformed entry caused the system to crash, which seems like a possible attack vector. For example, if InstantSend had been activated when this happened, would it have only used those few MNs that were showing as active? I could see a (likely implausible) scenario where someone could submit a proposal that brings down MNs and then uses the remaining ones to perform some type of attack. Is that really feasible? And has the underlying problem been completely fixed that caused this to happen in the first place?

    It is a bit disconcerting that a proposal submission would have any impact on the network, much less one so major as this one did.
     
    • Agree Agree x 5
  16. -crypto

    -crypto New Member
    Masternode Owner/Operator

    Joined:
    Jun 17, 2017
    Messages:
    15
    Likes Received:
    2
    Trophy Points:
    3
    After the Hotfix, how long does it take for DashCentral to recognize the MN's? Everything seems to check out on my end, and I'm good on Dash Ninja, but DashCentral still shows ERROR.
     
  17. Nthelight

    Nthelight New Member

    Joined:
    May 15, 2014
    Messages:
    26
    Likes Received:
    19
    Trophy Points:
    3
    Same issue on my side.
     
  18. nmarley

    nmarley Administrator
    Dash Core Team Moderator

    Joined:
    Jun 28, 2014
    Messages:
    337
    Likes Received:
    408
    Trophy Points:
    133
    Dash Address:
    XdBKajV4g2wnpnAvvnV9dxwypQMfFHYWtp
    I'd ask @rango about the status on DashCentral. Not sure where he's getting the data for that.
     
  19. Tony

    Tony New Member

    Joined:
    Sep 11, 2017
    Messages:
    10
    Likes Received:
    3
    Trophy Points:
    3
    Heya guys,
    I'd like your thoughts on having a cron job pulling every half an hour sentinel git. Something like
    Code:
    cd /home/dash/.dashcore/sentinel && /usr/bin/git pull 2>&1 >> sentinel-pull-cron.log
    Pros? Cons?
     
  20. oaxaca

    oaxaca Well-known Member
    Foundation Member

    Joined:
    Jul 8, 2014
    Messages:
    579
    Likes Received:
    842
    Trophy Points:
    263
    Here is an answer:

    Can you folks share any other tidbits about 12.2?
     
  21. Nthelight

    Nthelight New Member

    Joined:
    May 15, 2014
    Messages:
    26
    Likes Received:
    19
    Trophy Points:
    3
    FYI. Seems solved now.
     
  22. TanteStefana

    TanteStefana Moderator
    Linguistic Foundation Member

    Joined:
    Mar 9, 2014
    Messages:
    2,843
    Likes Received:
    1,861
    Trophy Points:
    1,283
    It's all because of those Europeans who use , instead of .

    Time to get out the whips (I volunteer ;P)
     
    • Funny Funny x 3
  23. TanteStefana

    TanteStefana Moderator
    Linguistic Foundation Member

    Joined:
    Mar 9, 2014
    Messages:
    2,843
    Likes Received:
    1,861
    Trophy Points:
    1,283
    I have an issue with 'watchdog expired' in testnet. I was unaware of it being gone?!
     
  24. t0dd

    t0dd Active Member
    Masternode Owner/Operator

    Joined:
    Mar 21, 2016
    Messages:
    137
    Likes Received:
    123
    Trophy Points:
    93
    Dash Address:
    XyxQq4qgp9B53QWQgSqSxJb4xddhzk5Zhh
    Note: For those running a masternode on Fedora, CentOS or RHEL and deploy the software via my repos -- ie: https://github.com/taw00/dashcore-rpm -- simply log onto your masternode server and type sudo dnf upgrade dashcore-sentinel -y and you are done.
     
    • Like Like x 1
  25. rango

    rango Active Member

    Joined:
    Jun 19, 2014
    Messages:
    159
    Likes Received:
    221
    Trophy Points:
    103
    The DashCentral issue related to this proposal has been resolved yesterday.
     
    • Like Like x 3
  26. demo

    demo Well-known Member

    Joined:
    Apr 23, 2016
    Messages:
    3,131
    Likes Received:
    262
    Trophy Points:
    153
    Dash Address:
    XnpT2YQaYpyh7F9twM6EtDMn1TCDCEEgNX
    As long as you are using interpreted languages and not compiled languages, this may happen. In EVERY update of the interpreted language or of its libraries, bad things may happen. Actually the one who controls the updates of the interpreted language, controls also the dash code, and consequently the whole dash network. Do you think satoshi was stupid, when he choosed a compiled language for his bitcoin?

    You may say, will the interpreted language developers do such a thing? Yes of course they will do it. We are talking about money religion, remember? For the religion of money, some people kill their own mother and father. The language developers could also target the MNO IP adresses and send only to those specific addresses a buggy language update. In such a case, when the dash network will accuse the language developers, all the rest world will have the correct version of the language and they will not believe Dash's accusations. Yet another reason you should hide the IPs of the MNOs and allow TOR or similar precautions.

    Fortunately for you, the masternode owners are complete stupid, they do not understand a word of all that I have just said, so they keep giving their dollars to dash. And this is a good thing, because although the dash generation is greedy, the dollar generation is much more greedy. So they deserve to be fooled.
     
    #26 demo, Oct 27, 2017
    Last edited: Oct 27, 2017
    • Creative Creative x 1
  27. Sven

    Sven New Member
    Masternode Owner/Operator

    Joined:
    Aug 15, 2017
    Messages:
    25
    Likes Received:
    5
    Trophy Points:
    3
    Reminds me of when the Mars Climate Orbiter software used imperial instead of metric units and $330m literally went "poof!"

    For a system that handles millions of dollars of value every day, there should be a top priority on validating and sanitizing ANY user input.
     
    • Agree Agree x 3
    • Funny Funny x 1
  28. camosoul

    camosoul Well-known Member

    Joined:
    Sep 19, 2014
    Messages:
    1,956
    Likes Received:
    1,088
    Trophy Points:
    183
    So many things are calling DASH into question now... How do you flub this?

    Where's 12.2?

    smh...

    You guys are making me facepalm so much I'm going to get a concussion...
     
    • Funny Funny x 1
  29. revelations86

    revelations86 Member

    Joined:
    Nov 12, 2016
    Messages:
    58
    Likes Received:
    20
    Trophy Points:
    48
    I had a very interesting situation happen which may a highlight a serious flaw. After 10/26, one of my masternodes showed as "inactive" on Ninja. However, when checking the status on Dashman, it reflected the network state as "enabled" , visible to ninja, and was counting down to payment extremely slowly. This discrepancy between what I was seeing on Ninja and by pulling the status on Dashman went on for a week, until I used the masternode start missing command which reset my place all the way back to the beginning (my place in cue was showing 4/4500 at that point but I didn't know whether this was real or not).

    Can someone explain how this discrepancy was possible?
     
  30. nnx3

    nnx3 New Member

    Joined:
    Apr 30, 2017
    Messages:
    22
    Likes Received:
    2
    Trophy Points:
    3
    • Trolling Trolling x 3

Share This Page