Welcome to the Dash Forum!

Please sign up to discuss the most innovative cryptocurrency!

Keepkey and Electrum?

Discussion in 'Electrum Wallet Support' started by wndsnb, Sep 2, 2017.

  1. wndsnb

    wndsnb New Member

    Joined:
    Aug 20, 2017
    Messages:
    8
    Likes Received:
    0
    Trophy Points:
    1
    Has anyone managed to get a Keepkey wallet working with Electrum-Dash?

    When I try to create a wallet with my Keepkey, I get this error:

    [​IMG]
     
  2. akhavr

    akhavr Active Member

    Joined:
    Oct 11, 2014
    Messages:
    749
    Likes Received:
    376
    Trophy Points:
    133
    I don't have a keepkey (looks like I have to buy one...)

    Please, make sure that you have the complete installation, in particular whether the hid module is installed correctly. I guess you're under linux, right?
     
  3. Dariusz Myśliwiec

    Dariusz Myśliwiec New Member

    Joined:
    Jul 8, 2017
    Messages:
    11
    Likes Received:
    3
    Trophy Points:
    3
    Actually I'm experiencing the same error. Seems like the KeepKey plugin in Electrum-Dash is outdated.
     
  4. akhavr

    akhavr Active Member

    Joined:
    Oct 11, 2014
    Messages:
    749
    Likes Received:
    376
    Trophy Points:
    133
    Is this happening only with keepkey wallet, or with regular wallets too?
     
  5. Dariusz Myśliwiec

    Dariusz Myśliwiec New Member

    Joined:
    Jul 8, 2017
    Messages:
    11
    Likes Received:
    3
    Trophy Points:
    3
    I got this error just while using the Electrum-Dash.
    EDIT: I'll try to elaborate on it and look for some fixes to it, but don't promise anything.
     
    #5 Dariusz Myśliwiec, Nov 15, 2017
    Last edited: Nov 15, 2017
  6. tungfa

    tungfa Administrator
    Dash Core Team Foundation Member Masternode Owner/Operator Moderator

    Joined:
    Apr 9, 2014
    Messages:
    8,961
    Likes Received:
    6,735
    Trophy Points:
    1,283
    did u try it with DMT App ? (no electrum but keepkey direct ) ?
     
  7. Dariusz Myśliwiec

    Dariusz Myśliwiec New Member

    Joined:
    Jul 8, 2017
    Messages:
    11
    Likes Received:
    3
    Trophy Points:
    3
    Didn't try this tool yet, since I thought it's related to MN operations. The problem I have is to retrieve the accounts to Electrum and do regular spending. If DMT have some module for KeepKey, I'll try to verify if it works fine and let you know, so the working code can be copied from DMT to Electrum.
     
  8. tungfa

    tungfa Administrator
    Dash Core Team Foundation Member Masternode Owner/Operator Moderator

    Joined:
    Apr 9, 2014
    Messages:
    8,961
    Likes Received:
    6,735
    Trophy Points:
    1,283
    my bad
    sorry thought we are talking MN here
    don't they have their own wallet as trezor.wallet ?
     
  9. Dariusz Myśliwiec

    Dariusz Myśliwiec New Member

    Joined:
    Jul 8, 2017
    Messages:
    11
    Likes Received:
    3
    Trophy Points:
    3
    No worries :)
    They do have their own web wallet, but the upgrades are slow (eg. for Dash it still has the higher fees for transactions). And the UI is pretty basic + no way to make multiple payments in one transaction.
     
    • Like Like x 1
  10. Dariusz Myśliwiec

    Dariusz Myśliwiec New Member

    Joined:
    Jul 8, 2017
    Messages:
    11
    Likes Received:
    3
    Trophy Points:
    3
    For now I can confirm that DMT works fine with my KeepKey on latest stable release.
    Didn't have time to confirm more, but seems like the replacement of support library for KeepKey should fix this problem.
     
    • Winner Winner x 1
  11. Dariusz Myśliwiec

    Dariusz Myśliwiec New Member

    Joined:
    Jul 8, 2017
    Messages:
    11
    Likes Received:
    3
    Trophy Points:
    3
    Seems like I found the issue and I'm happy to provide a fix for it. It works for me at least. Because I cannot create new issue in the offficial GitHub for this project (https://github.com/dashpay/electrum-dash), I'm providing the fix here. I hope somebody can commit the solution to the repository and rebuild the sources:
    In plugins/keepkey/keepkey.py there are missing lines at the end of the file, within KeepKeyPlugin class:
    Code:
      
        def hid_transport(self, pair):
            from keepkeylib.transport_hid import HidTransport
            return HidTransport(pair)
    
        def bridge_transport(self, d):
            raise NotImplementedError('')
    
    Please let me know if somebody will deal with it, or I can contribute somehow.

    Edit: Seems like the code is already there, but the binaries for Windows don't have the fragment I've mentioned, so it just have to be recompiled from sources.
     
    #11 Dariusz Myśliwiec, Nov 17, 2017
    Last edited: Nov 17, 2017
    • Like Like x 2
  12. tungfa

    tungfa Administrator
    Dash Core Team Foundation Member Masternode Owner/Operator Moderator

    Joined:
    Apr 9, 2014
    Messages:
    8,961
    Likes Received:
    6,735
    Trophy Points:
    1,283
    @akhavr
    i believe this one if for u
    tx
     
    • Like Like x 1
  13. UdjinM6

    UdjinM6 Official Dash Dev
    Dash Core Team Moderator

    Joined:
    May 20, 2014
    Messages:
    3,637
    Likes Received:
    3,536
    Trophy Points:
    1,183
    Eeeeks... o_O No idea why issues were not enabled... Fixed! :)
     
    • Winner Winner x 1
  14. akhavr

    akhavr Active Member

    Joined:
    Oct 11, 2014
    Messages:
    749
    Likes Received:
    376
    Trophy Points:
    133
    Thanks, this code will be included in our 2.9.3 release.
     
    • Like Like x 2